Conversation
noahsmartin
requested review from
alwx,
antonis and
lucas-zimerman
as code owners
Contributor
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 2b89ce9 | 413.69 ms | 442.58 ms | 28.89 ms |
| 90edad7+dirty | 423.57 ms | 438.92 ms | 15.35 ms |
| 21c9e75 | 450.39 ms | 452.92 ms | 2.53 ms |
| c08359e | 421.87 ms | 445.37 ms | 23.50 ms |
| 46bd012 | 387.09 ms | 404.47 ms | 17.38 ms |
| 955f2eb+dirty | 422.74 ms | 410.19 ms | -12.55 ms |
| 98f632c | 424.25 ms | 435.48 ms | 11.23 ms |
| 5c16cdc+dirty | 423.48 ms | 452.35 ms | 28.88 ms |
| 459a438+dirty | 417.09 ms | 406.52 ms | -10.57 ms |
| 20d5eaa | 377.62 ms | 406.50 ms | 28.88 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 2b89ce9 | 17.75 MiB | 19.68 MiB | 1.94 MiB |
| 90edad7+dirty | 17.75 MiB | 19.70 MiB | 1.95 MiB |
| 21c9e75 | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| c08359e | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| 46bd012 | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| 955f2eb+dirty | 17.75 MiB | 19.70 MiB | 1.95 MiB |
| 98f632c | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| 5c16cdc+dirty | 17.75 MiB | 19.68 MiB | 1.94 MiB |
| 459a438+dirty | 17.75 MiB | 19.70 MiB | 1.95 MiB |
| 20d5eaa | 17.75 MiB | 20.15 MiB | 2.41 MiB |
Collaborator
|
Shouldn't we apply this change to a major version since it removes the segment field from the current version? |
Contributor
Author
|
@lucas-zimerman it's in a major version of the iOS SDK, it didn't seem like it was part of the public API of the RN sdk (I don't think I touched any public API in this PR) but if it does change the public API it probably needs to be a major version of the RN sdk too |
Collaborator
|
It's safe to say it's not a break change since we don' document the segment field and the other SDKs are not using it |
Contributor
Android (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 000da7a+dirty | 347.89 ms | 381.98 ms | 34.09 ms |
| 20d5eaa+dirty | 358.31 ms | 442.37 ms | 84.06 ms |
| 90edad7+dirty | 372.57 ms | 398.83 ms | 26.26 ms |
| 46bd012+dirty | 333.76 ms | 359.24 ms | 25.48 ms |
| a0b15d6+dirty | 414.33 ms | 448.85 ms | 34.52 ms |
| 955f2eb+dirty | 388.13 ms | 433.56 ms | 45.44 ms |
| 23080e5+dirty | 347.29 ms | 381.87 ms | 34.58 ms |
| 5c16cdc+dirty | 375.45 ms | 426.62 ms | 51.17 ms |
| 459a438+dirty | 359.50 ms | 390.53 ms | 31.03 ms |
| c4e097a+dirty | 382.43 ms | 443.77 ms | 61.34 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 000da7a+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
| 20d5eaa+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| 90edad7+dirty | 7.15 MiB | 8.43 MiB | 1.28 MiB |
| 46bd012+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| a0b15d6+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| 955f2eb+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| 23080e5+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
| 5c16cdc+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
| 459a438+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| c4e097a+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
Collaborator
|
We could do a follow-up PR to remove the |
Contributor
iOS (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| a0b15d6+dirty | 1220.18 ms | 1223.18 ms | 3.00 ms |
| 59f3a84+dirty | 1232.56 ms | 1238.12 ms | 5.56 ms |
| c7f264b+dirty | 1211.82 ms | 1218.04 ms | 6.22 ms |
| 534ba8c+dirty | 1230.22 ms | 1231.18 ms | 0.96 ms |
| 46da307+dirty | 1217.08 ms | 1224.16 ms | 7.08 ms |
| 276d348+dirty | 1224.22 ms | 1227.38 ms | 3.16 ms |
| c9e95bd+dirty | 1240.19 ms | 1246.33 ms | 6.14 ms |
| b3b5b0d+dirty | 1227.71 ms | 1239.50 ms | 11.79 ms |
| 1853710+dirty | 1224.35 ms | 1230.18 ms | 5.84 ms |
| 083f560+dirty | 1227.33 ms | 1242.02 ms | 14.69 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| a0b15d6+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| 59f3a84+dirty | 2.63 MiB | 3.99 MiB | 1.36 MiB |
| c7f264b+dirty | 2.63 MiB | 3.91 MiB | 1.28 MiB |
| 534ba8c+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| 46da307+dirty | 2.63 MiB | 3.87 MiB | 1.24 MiB |
| 276d348+dirty | 2.63 MiB | 3.98 MiB | 1.34 MiB |
| c9e95bd+dirty | 2.63 MiB | 3.87 MiB | 1.24 MiB |
| b3b5b0d+dirty | 2.63 MiB | 3.91 MiB | 1.28 MiB |
| 1853710+dirty | 2.63 MiB | 3.91 MiB | 1.28 MiB |
| 083f560+dirty | 2.63 MiB | 4.00 MiB | 1.36 MiB |
Contributor
iOS (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| a0b15d6+dirty | 1213.79 ms | 1210.45 ms | -3.34 ms |
| 59f3a84+dirty | 1205.09 ms | 1213.31 ms | 8.23 ms |
| c7f264b+dirty | 1229.78 ms | 1225.84 ms | -3.94 ms |
| 534ba8c+dirty | 1225.00 ms | 1237.43 ms | 12.43 ms |
| 46da307+dirty | 1213.45 ms | 1207.96 ms | -5.49 ms |
| 276d348+dirty | 1222.10 ms | 1229.02 ms | 6.92 ms |
| c9e95bd+dirty | 1205.83 ms | 1207.38 ms | 1.55 ms |
| b3b5b0d+dirty | 1235.16 ms | 1238.61 ms | 3.45 ms |
| 1853710+dirty | 1213.67 ms | 1226.35 ms | 12.67 ms |
| 083f560+dirty | 1215.27 ms | 1231.96 ms | 16.69 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| a0b15d6+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| 59f3a84+dirty | 3.19 MiB | 4.56 MiB | 1.37 MiB |
| c7f264b+dirty | 3.19 MiB | 4.48 MiB | 1.29 MiB |
| 534ba8c+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| 46da307+dirty | 3.19 MiB | 4.44 MiB | 1.25 MiB |
| 276d348+dirty | 3.19 MiB | 4.54 MiB | 1.36 MiB |
| c9e95bd+dirty | 3.19 MiB | 4.44 MiB | 1.25 MiB |
| b3b5b0d+dirty | 3.19 MiB | 4.48 MiB | 1.29 MiB |
| 1853710+dirty | 3.19 MiB | 4.48 MiB | 1.29 MiB |
| 083f560+dirty | 3.19 MiB | 4.56 MiB | 1.38 MiB |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This property is deprecated and the next version of the iOS SDK will remove it entirely, so this deletes it from the RN code so that it will be compatible with the next iOS version
#skip-changelog